-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-31748: configure Werror #3949
Conversation
9f1568d
to
f9227a0
Compare
Patch is WIP, still fails to compile because AC_REPLACE_FUNC is broken:
|
While your PR fixes configure.ac for fchdir, fsync and fdatasync, there are still at least 39 compiler errors caused by -Werror -Wall. I started to write a list of them, but the list is too long :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please make sure to mention "-Werror -Wall" in the final commit message (once you click on [Merge]).
We can fix further compiler errors of configure in new PRs. This PR is already big enough :-)
Ping, @tiran. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz rebase
Support configure with -Wall by avoiding unused variables, e.g. (void)var. Signed-off-by: Christian Heimes <christian@python.org>
f9227a0
to
009fbed
Compare
Support configure with -Wall by avoiding unused variables, e.g.
(void)var.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue31748