Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31748: configure Werror #3949

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Oct 11, 2017

Support configure with -Wall by avoiding unused variables, e.g.
(void)var.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue31748

@tiran
Copy link
Member Author

tiran commented Oct 11, 2017

Patch is WIP, still fails to compile because AC_REPLACE_FUNC is broken:

gcc -pthread -c -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Werror -Wall -Wextra   -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Werror=implicit-function-declaration   -I. -I./Include    -DPy_BUILD_CORE -o Python/strdup.o Python/strdup.c
In file included from /usr/include/string.h:634:0,
                 from ./Include/Python.h:30,
                 from ./Include/pgenheaders.h:10,
                 from Python/strdup.c:3:
Python/strdup.c:6:1: error: expected identifier or ‘(’ before ‘__extension__’
 strdup(const char *str)
 ^

@vstinner
Copy link
Member

While your PR fixes configure.ac for fchdir, fsync and fdatasync, there are still at least 39 compiler errors caused by -Werror -Wall. I started to write a list of them, but the list is too long :-)

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make sure to mention "-Werror -Wall" in the final commit message (once you click on [Merge]).

We can fix further compiler errors of configure in new PRs. This PR is already big enough :-)

@taleinat taleinat closed this Sep 6, 2018
@taleinat taleinat reopened this Sep 6, 2018
@taleinat
Copy link
Contributor

taleinat commented Sep 6, 2018

Ping, @tiran.

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz rebase

Support configure with -Wall by avoiding unused variables, e.g.
(void)var.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the bpo-31748-configure-Werror branch from f9227a0 to 009fbed Compare May 29, 2019 08:48
@tiran tiran closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants