bpo-30693: Fix tarfile test cleanup on MSWindows #5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes the test passing. But mocking os.listdir which is used in a cleaning up code looks unsafe to me. This can left files when really something prevented from deleting them immediately (this is happened on Windows with an antivirus detector). It would be better to restore the original os.listdir before starting the cleaning up. |
bmwiedemann
force-pushed
the
tarfile
branch
2 times, most recently
from
74e3592
to
5c18489
Compare
it was using our mocked listdir to check when the files were gone
|
updated to only have the mocked version for tar.add |
|
@serhiy-storchaka: Please replace |
|
Thanks @bmwiedemann for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 6, 2018
it was using our mocked listdir to check when the files were gone. (cherry picked from commit 4ad703b) Co-authored-by: Bernhard M. Wiedemann <githubbmw@lsmod.de>
|
GH-5567 is a backport of this pull request to the 3.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lib/test/support/__init__.py#L334was using our mocked listdir to check when the deleted files were gone - and thus it thought they remained therenote: someone with MSWindows needs to test this fix
https://bugs.python.org/issue30693