bpo-29756: Improve documentation for list methods that compare items by equality #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyangyu
added
docs
|
@zhangyangyu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @ncoghlan, @benjaminp, @ezio-melotti and @tiran to be potential reviewers. |
vadmium
reviewed
Mar 12, 2017
Doc/tutorial/datastructures.rst
Outdated
| @@ -40,7 +40,7 @@ objects: | |||
| .. method:: list.remove(x) | |||
| :noindex: | |||
|
|
|||
| Remove the first item from the list whose value is *x*. It is an error if | |||
| Remove the first item from the list whose value equals to *x*. It is an error if | |||
There was a problem hiding this comment.
equals to → equals [or write “is equal to” like above]
Mariatta
reviewed
Mar 12, 2017
Doc/tutorial/datastructures.rst
Outdated
| @@ -40,7 +40,7 @@ objects: | |||
| .. method:: list.remove(x) | |||
| :noindex: | |||
|
|
|||
| Remove the first item from the list whose value is *x*. It is an error if | |||
| Remove the first item from the list whose value equals to *x*. It is an error if | |||
There was a problem hiding this comment.
Maybe say, Raises a ValueError if there is no such item.
There was a problem hiding this comment.
In my mind they don't have any difference. :-(
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@1.8.0...1.9.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.