[2.7] bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found (GH-5240) #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SND chunk is not found (pythonGH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
@ZackerySpytz and @serhiy-storchaka: Backport status check is done, and it's a failure ❌ . |
|
The backport to 2.7 needs to use |
serhiy-storchaka
previously approved these changes
Feb 20, 2018
serhiy-storchaka
dismissed
their stale review
May need manual editing of the commit message.
|
@serhiy-storchaka I think miss-islington won't auto merge since you made an additional commit. So you'll have to merge this PR manually. It also failed to report the new status check. |
|
I dismissed my approve for preventing auto merge because I didn't know how @miss-islington handles the case of multiple commits. |
|
Thanks, @serhiy-storchaka! |
|
It's not yet handling the multiple commits case :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize self._ssnd_chunk so that aifc.Error is raised as intended,
not AttributeError.
(cherry picked from commit 80d20b9)
Co-authored-by: Zackery Spytz zspytz@gmail.com
https://bugs.python.org/issue31848