Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-28677: Improve phrasing of when instance attribute is referenced #6208

Merged
merged 1 commit into from
Jul 25, 2018
Merged

bpo-28677: Improve phrasing of when instance attribute is referenced #6208

merged 1 commit into from
Jul 25, 2018

Conversation

aaronang
Copy link
Contributor

@aaronang aaronang commented Mar 24, 2018 •
edited by bedevere-bot
Loading

Fixes bpo-28677 using David's proposed solution.

https://bugs.python.org/issue28677

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@aaronang
Copy link
Contributor Author

aaronang commented Apr 9, 2018

CLA has been signed 😬

@taleinat taleinat added docs Documentation in the Doc dir needs backport to 3.6 skip news labels Jul 25, 2018
@taleinat taleinat merged commit c0f0a76 into python:master Jul 25, 2018
@miss-islington
Copy link
Contributor

Thanks @aaronang for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @aaronang and @taleinat, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c0f0a7669c73c0d444851dd4c5299de2479214cc 3.7

@bedevere-bot
Copy link

GH-8461 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2018
@aaronang @miss-islington
bpo-28677: Improve phrasing of when instance attribute is referenced (p…
836b8f4 
…ythonGH-6208)

(cherry picked from commit c0f0a76)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
@bedevere-bot
Copy link

GH-8462 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2018
@aaronang @miss-islington
bpo-28677: Improve phrasing of when instance attribute is referenced (p…
2691e31 
…ythonGH-6208)

(cherry picked from commit c0f0a76)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
@miss-islington
Copy link
Contributor

Thanks @aaronang for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2018
@aaronang @miss-islington
bpo-28677: Improve phrasing of when instance attribute is referenced (p…
ff5c737 
…ythonGH-6208)

(cherry picked from commit c0f0a76)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
@bedevere-bot
Copy link

GH-8469 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jul 25, 2018
@miss-islington @aaronang
bpo-28677: Improve phrasing of when instance attribute is referenced (G…
1c8f655 
…H-6208)

(cherry picked from commit c0f0a76)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jul 25, 2018
@miss-islington @aaronang
bpo-28677: Improve phrasing of when instance attribute is referenced (G…
cfadd1c 
…H-6208)

(cherry picked from commit c0f0a76)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
taleinat pushed a commit that referenced this pull request Jul 25, 2018
@miss-islington @aaronang @taleinat
bpo-28677: Improve phrasing of when instance attribute is referenced (G…
ec02c58 
…H-6208)

(cherry picked from commit c0f0a76)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@taleinat taleinat

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aaronang @the-knights-who-say-ni @miss-islington @bedevere-bot @taleinat @Mariatta