bpo-33205: dict: Change GROWTH_RATE to (used*3) #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
changed the title
methane
requested review from
vstinner,
ericsnowcurrently,
rhettinger and
serhiy-storchaka
serhiy-storchaka
approved these changes
Apr 16, 2018
| @@ -0,0 +1,2 @@ | |||
| Change dict growth function from ``round_up_to_power_2(used*2+capacity/2)`` to ``round_up_to_power_2(used*3)``. | |||
There was a problem hiding this comment.
I would use "hashtable_size" instead if "capacity". The capacity is only 2/3 of the hashtable size.
Objects/dictobject.c
Outdated
| * This means that dicts double in size when growing without deletions, | ||
| * but have more head room when the number of deletions is on a par with the | ||
| * number of insertions. | ||
| * number of insertions. See also bpo-17563 and bpo-33205. | ||
| * Raising this to used*4 doubles memory consumption depending on the size of |
There was a problem hiding this comment.
Is this note still relevant?
|
Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 17, 2018
(cherry picked from commit 5fbc511) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
|
GH-6503 is a backport of this pull request to the 3.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33205