bpo-29799 Adding tests for HTTP header API of urllib.request.Request class #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re provided as constructor arguments
|
@ultimatecoder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @orsenthil, @birkenfeld, @benjaminp and @serhiy-storchaka to be potential reviewers. |
vadmium
reviewed
Mar 12, 2017
| def test_request_with_headers(self): | ||
| """Verify headers if passed as a constructor argument.""" | ||
| request = self.Request("http://www.python.org", headers=self.headers) | ||
| self.assertDictEqual(request.headers, self.headers) |
There was a problem hiding this comment.
Redundant with test_urllib2.RequestHdrsTests.test_request_headers_dict
vadmium
reviewed
Mar 12, 2017
| """Verify presence of headers is marked.""" | ||
| request = self.Request("http://www.python.org", headers=self.headers) | ||
| self.assertTrue(request.has_header('User-agent')) | ||
| self.assertFalse(request.has_header('Content-type')) |
There was a problem hiding this comment.
Test_urllib2.RequestHdrsTests.test_request_headers_methods already tests “has_header” against a constructor-supplied header field, and also has a negative test.
| self.assertListEqual( | ||
| request.header_items(), | ||
| list(self.headers.items()) | ||
| ) |
There was a problem hiding this comment.
Also covered by “test_request_headers_methods”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adding various tests for all the HTTP header related methods of
urllib.request.Requestclass.BPO: http://bugs.python.org/issue29799