Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33308: Fix a crash in the parser module when convert an ST object. #6519

Merged
merged 2 commits into from
Apr 18, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 18, 2018

Converting with line_info=False and col_info=True crashed before.

https://bugs.python.org/issue33308

Converting with line_info=False and col_info=True crashed before.
@serhiy-storchaka serhiy-storchaka merged commit e5362ea into python:master Apr 18, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

@serhiy-storchaka serhiy-storchaka deleted the parser-col_info-only branch April 18, 2018 22:55
@bedevere-bot
Copy link

GH-6526 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 18, 2018
pythonGH-6519)

Converting with line_info=False and col_info=True crashed before.
(cherry picked from commit e5362ea)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 18, 2018
pythonGH-6519)

Converting with line_info=False and col_info=True crashed before.
(cherry picked from commit e5362ea)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-6527 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e5362eaa75a154c6e91c5b1c47719d0a0f5ca48b 2.7

miss-islington added a commit that referenced this pull request Apr 19, 2018
GH-6519)

Converting with line_info=False and col_info=True crashed before.
(cherry picked from commit e5362ea)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Apr 19, 2018
GH-6519)

Converting with line_info=False and col_info=True crashed before.
(cherry picked from commit e5362ea)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 19, 2018
…object. (pythonGH-6519)

Converting with line_info=False and col_info=True crashed before..
(cherry picked from commit e5362ea)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-6532 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka added a commit that referenced this pull request Apr 19, 2018
…object. (GH-6519) (GH-6532)

Converting with line_info=False and col_info=True crashed before.
(cherry picked from commit e5362ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants