Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in __mul__ docstring #6674

Merged
merged 1 commit into from May 8, 2018

Conversation

grantjenks
Copy link
Contributor

@grantjenks grantjenks commented May 1, 2018

Fix typo in __mul__ docstring.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@grantjenks
Copy link
Contributor Author

I seem to be blocked on "CLA not signed". The CPython devguide says:

"""
After signing the CLA, please wait at least one US business day and then check “Your Details” on b.p.o to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA). Once you have verified that your b.p.o account reflects your signing of the CLA, you can either ask for the CLA check to be run again or wait for it to be run automatically the next time you push changes to your PR.
"""

I've signed and submitted the CLA and waited 3 business days but still "Contributor Form Received" on https://bugs.python.org/user27001 is blank. You can view the signed contributor form at http://www.grantjenks.com/docs/Python-Contributor-Agreement-Form-Signed.pdf

Please let me know if there's anything that needs correcting.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are here, it is worth to fix a docsting for __rmul__ below. Currently it is "Return self*value.", but should be "Return value*self.".

@serhiy-storchaka
Copy link
Member

Thank you for your contribution @grantjenks! Your signing of the CLA will be accepted manually, it takes a time. But I think that signing the CLA for such trivial fix is not required and going to merge it not waiting the acceptance.

Though it would be good if you will fix other error two line below in this PR.

@grantjenks
Copy link
Contributor Author

Hi @serhiy-storchaka! I've seen your name occasionally on the python mailing lists. Nice to meet you this way too :)

I fixed the other typo two lines below the original patch. Good catch!

@serhiy-storchaka serhiy-storchaka merged commit 0904f76 into python:master May 8, 2018
@miss-islington
Copy link
Contributor

Thanks @grantjenks for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2018
(cherry picked from commit 0904f76)

Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
@bedevere-bot
Copy link

GH-6733 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2018
(cherry picked from commit 0904f76)

Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
@bedevere-bot
Copy link

GH-6734 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @grantjenks and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0904f766e116c269675317e11368a4d29eef0bc6 2.7

miss-islington added a commit that referenced this pull request May 9, 2018
(cherry picked from commit 0904f76)

Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
miss-islington added a commit that referenced this pull request May 9, 2018
(cherry picked from commit 0904f76)

Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
@grantjenks grantjenks deleted the fix_mul_typo branch May 9, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants