New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in __mul__ docstring #6674
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
I seem to be blocked on "CLA not signed". The CPython devguide says: """ I've signed and submitted the CLA and waited 3 business days but still "Contributor Form Received" on https://bugs.python.org/user27001 is blank. You can view the signed contributor form at http://www.grantjenks.com/docs/Python-Contributor-Agreement-Form-Signed.pdf Please let me know if there's anything that needs correcting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are here, it is worth to fix a docsting for __rmul__
below. Currently it is "Return self*value."
, but should be "Return value*self."
.
Thank you for your contribution @grantjenks! Your signing of the CLA will be accepted manually, it takes a time. But I think that signing the CLA for such trivial fix is not required and going to merge it not waiting the acceptance. Though it would be good if you will fix other error two line below in this PR. |
Hi @serhiy-storchaka! I've seen your name occasionally on the python mailing lists. Nice to meet you this way too :) I fixed the other typo two lines below the original patch. Good catch! |
Thanks @grantjenks for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
(cherry picked from commit 0904f76) Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
GH-6733 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 0904f76) Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
GH-6734 is a backport of this pull request to the 3.6 branch. |
Sorry, @grantjenks and @serhiy-storchaka, I could not cleanly backport this to |
(cherry picked from commit 0904f76) Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
(cherry picked from commit 0904f76) Co-authored-by: Grant Jenks <grant.jenks@gmail.com>
Fix typo in
__mul__
docstring.