-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-33772: Fix couple of dead code paths #7418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ast.c and compile.c, break
before next case
seems worth.
It notes that "this case clause doesn't fallthrough".
Others seems good to me.
In ast.c and compile.c they always return before the |
I know. But the case clause is not so simple. It takes several seconds to read code for knowing it. |
I hope I m not asking too much :-) but any opinion on this older PR ? |
Closing and re-opening to retrigger CI checks. |
@dcarlier-afilias, thank you for the pull request and, @methane, thank you for the code review and approval. |
https://bugs.python.org/issue33772