Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33904: IDLE: In rstrip, rename class RstripExtension as Rstrip #7811

Merged
merged 2 commits into from
Jun 20, 2018
Merged

bpo-33904: IDLE: In rstrip, rename class RstripExtension as Rstrip #7811

merged 2 commits into from
Jun 20, 2018

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Jun 20, 2018 •
edited by bedevere-bot
Loading

@srinivasreddy
IDLE: In rstrip, rename class RstripExtension as Rstrip
3e21ce9 
Signed-off-by: Srinivas Reddy Thatiparthy <thatiparthysreenivas@gmail.com>
@srinivasreddy srinivasreddy changed the title IDLE: In rstrip, rename class RstripExtension as Rstrip bpo-33904: IDLE: In rstrip, rename class RstripExtension as Rstrip Jun 20, 2018
terryjreedy
terryjreedy requested changes Jun 20, 2018
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please add a news item, using blurb. For whatever reason, I cannot push one. Use this:
In module rstrip, rename class RstripExtension as Rstrip.

In the future, please include one with the PR. The exact content does not matter, as it can be edited via the web page, which is much easier than pulling and pushing. This is otherwise ready to merge.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@terryjreedy
Copy link
Member

If you are looking for another easy issue, try bpo-33906.

@srinivasreddy
Add News entry
81dc36c 
Signed-off-by: Srinivas Reddy Thatiparthy <thatiparthysreenivas@gmail.com>
@terryjreedy terryjreedy merged commit 9bb9223 into python:master Jun 20, 2018
@miss-islington
Copy link
Contributor

Thanks @srinivasreddy for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-7814 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2018
@srinivasreddy @miss-islington
bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (p…
2d9070c 
…ythonGH-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
@bedevere-bot
Copy link

GH-7815 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2018
@srinivasreddy @miss-islington
bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (p…
a6414cc 
…ythonGH-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jun 20, 2018
@miss-islington @srinivasreddy
bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (G…
b0f3526 
…H-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jun 20, 2018
@miss-islington @srinivasreddy
bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (G…
b41dc56 
…H-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srinivasreddy @bedevere-bot @terryjreedy @miss-islington @the-knights-who-say-ni