Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33922: Adding documentation for new "-64" suffix of python launcher #7849

Merged
merged 1 commit into from Apr 12, 2019
Merged

bpo-33922: Adding documentation for new "-64" suffix of python launcher #7849

merged 1 commit into from Apr 12, 2019

Conversation

mrh1997
Copy link
Contributor

@mrh1997 mrh1997 commented Jun 21, 2018 •
edited by bedevere-bot

since bpo-30291 it is possible to specify as bit length of the python
version to be not only 32bit but alternatively to be 64bit.

https://bugs.python.org/issue33922

csabella
csabella reviewed Mar 19, 2019
View reviewed changes
Doc/using/windows.rst Outdated Show resolved Hide resolved
csabella
csabella reviewed Mar 19, 2019
View reviewed changes
Doc/using/windows.rst Outdated Show resolved Hide resolved
csabella
csabella reviewed Mar 19, 2019
View reviewed changes
Doc/using/windows.rst Outdated Show resolved Hide resolved
csabella
csabella reviewed Mar 19, 2019
View reviewed changes
Doc/using/windows.rst Outdated Show resolved Hide resolved
csabella
csabella reviewed Mar 19, 2019
View reviewed changes
Doc/using/windows.rst Outdated Show resolved Hide resolved
@csabella csabella requested a review from zooba March 19, 2019 23:18
@mrh1997 mrh1997 force-pushed the fix-bpo-33922 branch 2 times, most recently from f47d85a to 6d45231 Compare March 20, 2019 01:34
zooba
zooba requested changes Apr 12, 2019
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some readability improvements, but there's one particular section that is out of date so let's update the whole section now.

Doc/using/windows.rst Outdated Show resolved Hide resolved
Doc/using/windows.rst Outdated Show resolved Hide resolved
Doc/using/windows.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mrh1997 mrh1997 force-pushed the fix-bpo-33922 branch 2 times, most recently from afca5a3 to fa1cd28 Compare April 12, 2019 21:13
@mrh1997
bpo-33922: Adding documentation for new "-64" suffix of python launcher
09f8f01 
since bpo-30291 it is possible to specify as bit length of the python
version to be not only 32-bit but alternatively to be 64-bit.
@mrh1997
Copy link
Contributor Author

mrh1997 commented Apr 12, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@zooba: please review the changes made to this pull request.

@zooba
Copy link
Member

zooba commented Apr 12, 2019

For what it's worth, when you force push an update it means I can't review your changes and have to re-review the whole thing again. We always squash and edit commit messages, which means the final result looks neat no matter how many commits it took to get there.

Thanks for the improvements!

@zooba zooba merged commit 1e2ad6c into python:master Apr 12, 2019
@miss-islington
Copy link
Contributor

Thanks @mrh1997 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2019
@mrh1997 @miss-islington
bpo-33922: Adding documentation for new "-64" suffix of Python launch…
02db8f8 
…er (pythonGH-7849)

Since bpo-30291 it is possible to specify the architecture of Python when using the launcher
(cherry picked from commit 1e2ad6c)

Co-authored-by: mrh1997 <mrh1997@users.noreply.github.com>
@bedevere-bot
Copy link

GH-12812 is a backport of this pull request to the 3.7 branch.

@mrh1997 mrh1997 deleted the fix-bpo-33922 branch April 12, 2019 22:29
miss-islington added a commit that referenced this pull request Apr 12, 2019
@miss-islington @mrh1997
bpo-33922: Adding documentation for new "-64" suffix of Python launch…
395bb94 
…er (GH-7849)

Since bpo-30291 it is possible to specify the architecture of Python when using the launcher
(cherry picked from commit 1e2ad6c)

Co-authored-by: mrh1997 <mrh1997@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella left review comments

@zooba zooba zooba approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mrh1997 @bedevere-bot @zooba @miss-islington @csabella @the-knights-who-say-ni