bpo-23699: Use a macro to reduce boilerplate code in rich comparison functions #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stratakis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @freddrake, @loewis and @benjaminp to be potential reviewers. |
ncoghlan
approved these changes
May 30, 2017
|
Thanks for taking a look at it Nick. Will update the PR with the Misc/NEWS and Misc/ACKS files. Do you think it would be possible to backport this change to the 3.6 branch? Should I make a PR for a backport as well? |
stratakis
force-pushed
the
richcompare_macro
branch
from
d730285
to
c947ff2
Compare
|
No, it's a new feature, so projects will need to either define it themselves or get it from a compatibility project like Py3C for older releases. |
stratakis
force-pushed
the
richcompare_macro
branch
from
c947ff2
to
d6faeea
Compare
stratakis
force-pushed
the
richcompare_macro
branch
from
d6faeea
to
7e7779e
Compare
|
PR has been rebased on top of master and the tests pass. Is there some way I can help moving this forward? |
ncoghlan
approved these changes
Nov 2, 2017
|
Thanks! |
embray
pushed a commit
to embray/cpython
that referenced
this pull request
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch from @encukou
More info at: http://bugs.python.org/issue23699
Rebased for the current master branch.
https://bugs.python.org/issue23699