Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: build Python in 64-bit mode #8363

Merged
merged 1 commit into from
Jul 23, 2018
Merged

AppVeyor: build Python in 64-bit mode #8363

merged 1 commit into from
Jul 23, 2018

Conversation

vstinner
Copy link
Member

Previously, Python was built in 32-bit mode and so issues specific to
64-bit mode like compiler warnings could be missed.

Previously, Python was built in 32-bit mode and so issues specific to
64-bit mode like compiler warnings could be missed.
@vstinner
Copy link
Member Author

Example of a recent warning missed by AppVeyor: #8359

@serhiy-storchaka
Copy link
Member

Couldn't issues specific to 32-bit mode be missed?

@vstinner
Copy link
Member Author

vstinner commented Jul 21, 2018 via email

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Windows expert, but these changes LGTM.

@zware
Copy link
Member

zware commented Jul 21, 2018

My goal for AppVeyor is just speed (that's why it builds in Release configuration rather than Debug), so I'd rather it use whichever is faster between 32- and 64-bit. If they're effectively the same, then switching to 64-bit is fine with me.

FTR, VSTS already does both 32- and 64-bit builds, and it appears from those logs that 64-bit is generally about 2 minutes slower than 32-bit.

@vstinner
Copy link
Member Author

vstinner commented Jul 23, 2018

FTR, VSTS already does both 32- and 64-bit builds, and it appears from those logs that 64-bit is generally about 2 minutes slower than 32-bit.

I looked at AppVeyor tests timing:

  • 32-bit: 4 min 44 sec
  • 64-bit: 4 min 38 sec

So there is no significant difference.

--

I looked at the "VSTS: Windows" logs on this PR: I confirm that the 64 bits build is 2 min slower than the 32 bits build. No idea why. But this PR only changes AppVeyor configuration.

@vstinner vstinner merged commit 8b96eed into python:master Jul 23, 2018
@vstinner vstinner deleted the appveyor_64bit branch July 23, 2018 11:16
@vstinner
Copy link
Member Author

I switched AppVeyor to 64-bit on the master branch. My use case is to catch compiler warnings, and usually I only fix compiler warnings in the master branch. So I'm not sure about backporting this change to 2.7, 3.6 and 3.7 branches. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants