bpo-34421 Fix unicode error on Windows #8799
Conversation
This fixes an issue reported to setuptools that prevents the installation of packages containing unicode module or package names in Windows: pypa/setuptools#1399
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
julienmalard
changed the title
|
Can you add a news entry? |
|
Done! Please let me know if I got it correctly. |
|
Looks like you did not push :) |
|
Ah, sorry about that! |
| @@ -0,0 +1,2 @@ | |||
| Fixed installation issue with setuptools setuptools that crashed with | |||
| packages containing unicode module or package names in Windows. | |||
There was a problem hiding this comment.
The directories are messed up here.
Minor things:
- Can you put this in the Library section instead of Windows? It is a distutils change on all platforms.
- Mention distutils, not setuptools.
|
Thanks @julienmalard for the PR, and @merwok for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Thanks @julienmalard for the PR, and @merwok for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
This caused installation errors in some cases on Windows. Patch by Julien Malard. (cherry picked from commit 0afada1) Co-authored-by: Julien Malard <julien.malard@mail.mcgill.ca>
|
GH-9117 is a backport of this pull request to the 3.6 branch. |
This caused installation errors in some cases on Windows. Patch by Julien Malard. (cherry picked from commit 0afada1) Co-authored-by: Julien Malard <julien.malard@mail.mcgill.ca>
|
GH-9118 is a backport of this pull request to the 3.7 branch. |
This fixes an issue reported to setuptools that prevents the installation of packages containing unicode module or package names in Windows:
pypa/setuptools#1399
https://bugs.python.org/issue34421