Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34421 Fix unicode error on Windows #8799

Merged
merged 5 commits into from Sep 8, 2018
Merged

bpo-34421 Fix unicode error on Windows #8799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
990720b
Fix unicode error on Windows
julienmalard Aug 17, 2018
825a483
Create 2018-09-07-10-57-00.bpo-34421.AKJISD.rst
julienmalard Sep 7, 2018
eb39836
Create 2018-09-07-10-57-00.bpo-34421.AKJISD.rst
julienmalard Sep 7, 2018
0b44dc9
Delete 2018-09-07-10-57-00.bpo-34421.AKJISD.rst
julienmalard Sep 7, 2018
d6a1788
Update news
merwok Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/distutils/log.py
View file
Open in desktop
Expand Up @@ -31,7 +31,10 @@ def _log(self, level, msg, args):
# emulate backslashreplace error handler
encoding = stream.encoding
msg = msg.encode(encoding, "backslashreplace").decode(encoding)
stream.write('%s\n' % msg)
try:
stream.write('%s\n' % msg)
except UnicodeEncodeError:
stream.write('%s\n' % msg.encode('unicode-escape').decode('ascii'))
stream.flush()

def log(self, level, msg, *args):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2018-09-07-10-57-00.bpo-34421.AKJISD.rst
View file
Open in desktop
@@ -0,0 +1 @@
Fix distutils logging for non-ASCII strings. This caused installation issues on Windows.