gh-79156: Add start_tls() method to streams API #91453
Conversation
The existing event loop `start_tls()` method is not sufficient for connections using the streams API. The existing StreamReader works because the new transport passes received data to the original protocol. The StreamWriter must then write data to the new transport, and the StreamReaderProtocol must be updated to close the new transport correctly. The new StreamWriter `start_tls()` updates itself and the reader protocol to the new SSL transport.
|
All commit authors signed the Contributor License Agreement. |
|
Ian Good signed the CLA before publishing the original PR. |
Cc. @ambv |
|
Sorry for the trouble! I'm off work now, I added this case to look at tomorrow morning. |
|
Fixed a usage of the |
|
Just noticed this -- @arhadthedev @ambv anything I can do to help? |
|
@icgood, can you click on the red button in #91453 (comment) to re-sign the CLA? |
|
@ambv Thank you a lot for merging! The paired function, |
| handshake to complete before aborting the connection. ``60.0`` seconds | ||
| if ``None`` (default). | ||
|
|
||
| .. versionadded:: 3.8 |
There was a problem hiding this comment.
Should be 3.11 isn't it ?
There was a problem hiding this comment.
Right, missed it. Good catch, @kumaraditya303. @arhadthedev, you could fix this while working on shutdown_tls.
A reupload of gh-13143 with the ported whatsnew since the original author is waiting for three years already. For strange reason, the original branch is missing and the PR has no corresponding "{username} deleted the {branch} branch" notification line.
The PR is revived after a thread on python-dev:
Linked to gh-79156; the original issue may be closed with the following
stop_tls()PR.Co-authored-by: Ian Good icgood@gmail.com