Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-92822: IDLE - Add a selection label to window statusbars #92823

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

tomlin7
Copy link

@tomlin7 tomlin7 commented May 15, 2022

When a selection is made, add a selection label after cursor row/column labels.
While a selection is present, update it on <<set-line-and-column event>>.

- create new statusbar label called selected
- update label selected on set-line-and-column event
@tomlin7 tomlin7 requested a review from terryjreedy as a code owner May 15, 2022 17:38
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 15, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@tomlin7 tomlin7 changed the title gh-#92822: Added "selected" section to IDLE statusbar gh-92822: Added "selected" section to IDLE statusbar May 15, 2022
@AlexWaygood AlexWaygood added type-feature A feature request or enhancement topic-IDLE labels May 15, 2022
Lib/idlelib/editor.py Outdated Show resolved Hide resolved
@terryjreedy
Copy link
Member

I have not yet accepted the addition, let alone the format; further edits should await approval of both. See issue.

If accepted, new tests will be needed. Running tests before they are added is useless.

@terryjreedy terryjreedy changed the title gh-92822: Added "selected" section to IDLE statusbar gh-92822: IDLE - Add a selection label to window statusbars Jul 24, 2022
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change applies regardless of possible format change.

Lib/idlelib/editor.py Outdated Show resolved Hide resolved
Lib/idlelib/editor.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@tomlin7
Copy link
Author

tomlin7 commented Jul 24, 2022

@terryjreedy I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants