-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-92822: IDLE - Add a selection label to window statusbars #92823
base: main
Are you sure you want to change the base?
Conversation
- create new statusbar label called selected - update label selected on set-line-and-column event
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
I have not yet accepted the addition, let alone the format; further edits should await approval of both. See issue. If accepted, new tests will be needed. Running tests before they are added is useless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change applies regardless of possible format change.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy I have made the requested changes; please review again |
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
When a selection is made, add a selection label after cursor row/column labels.
While a selection is present, update it on
<<set-line-and-column event>>
.