-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-78913: modified to return uuid version between 1 to 5 based on RFC 4122 #9413
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
@arhadthedev thank you for adding the news entry. Since this is my first fix and pr :) I am just curious and excited about which release these changes are getting into. Could someone please let me know? |
This PR needs tests. I'll try to add them later today. |
This is my first PR and I am very curious to get this moving forward. I am willing to spend time and bring this to a closure since this is in an open state for a long time. |
It would be amazing and grateful if someone could point me to a documentation about what is pending to get this pr reviewed. Looking forward to the community's reply. Thank you! |
I think the PR is fine, but I don't think we want this change. There's nothing in the spec that says versions other than 1-5 are invalid, just that they aren't currently defined, and our docs say that we will return the version and it may not be meaningful. This change would require us to update the documentation to say that we may not return the version field if it is an undefined value. I'll cross-post on #78913, which is where this discussion should happen. |
It is the docs that are wrong, not the implementation. |
https://bugs.python.org/issue34732