bpo-34876: Change the lineno of the AST for decorated function and class. #9731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass. It was overridden by the lineno of the first decorator. Now it is the lineno of 'def' or 'class'.
This was referenced Nov 22, 2018
openstack-gerrit
pushed a commit
to openstack/rally
that referenced
this pull request
Feb 28, 2020
* remove a hack for python3.4 from rally-tox-base job * raise version of SQLAlchemy at upper-constraints.txt to avoid new warnings at python 3.8 env * install python from the ubuntu repos instead of deadsnakes * cover https://bugs.python.org/issue35894 * skip tests.unit.common.io.test_junit for Python 3.8. The failures relate to changed order of xml tag parameters. It is not critical and rally.common.io.junit is not used at all (abandoned code?!) * cover python/cpython#9731 Closes-Bug: #1864987 Change-Id: Iffb0015fbae48eb69e683ef41b9763798f198130
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Feb 28, 2020
* Update rally from branch 'master'
- Merge "Ensure python 3.8 is supported"
- Ensure python 3.8 is supported
* remove a hack for python3.4 from rally-tox-base job
* raise version of SQLAlchemy at upper-constraints.txt to avoid new
warnings at python 3.8 env
* install python from the ubuntu repos instead of deadsnakes
* cover https://bugs.python.org/issue35894
* skip tests.unit.common.io.test_junit for Python 3.8. The failures
relate to changed order of xml tag parameters. It is not critical and
rally.common.io.junit is not used at all (abandoned code?!)
* cover python/cpython#9731
Closes-Bug: #1864987
Change-Id: Iffb0015fbae48eb69e683ef41b9763798f198130
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was overridden by the lineno of the first decorator. Now it is
the lineno of 'def' or 'class'.
https://bugs.python.org/issue34876