Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Add Python 3.8 support #12

Closed
mschwager opened this issue Jul 19, 2019 · 2 comments
Closed

Add Python 3.8 support #12

mschwager opened this issue Jul 19, 2019 · 2 comments

Comments

@mschwager
Copy link
Collaborator

We've recently included Python 3.8 in our CI system (although failures are allowed). The tests are currently failing on this version, see here.

We should fix the tests and add Python 3.8 support before it is officially released. It appears this version will be officially released sometime in October: PEP 569.

@mschwager
Copy link
Collaborator Author

@mschwager
Copy link
Collaborator Author

mschwager commented Sep 10, 2019

I believe this should be fixed in Python 3.8.0 beta 4, whereas TravisCI 3.8-dev appears to still be on 3.8.0 beta 3.

I misread the issues, per this PR (python/cpython#9731):

The lineno and col_offset attributes of the AST for decorated function
and class refer now to the position of the corresponding def, async def and class instead of the position of the first decorator. This
leads to more correct line reporting in tracing. This is the only case when
the position of child AST nodes can preceed the position of the parent AST
node.

We'll have to account for this discrepancy between 3.8+ and < 3.8.

xen0l pushed a commit to xen0l/dlint that referenced this issue Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant