gh-87597: Document TimeoutExpired.stdout & .stderr types. #97685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documents the behavior that has always been the case since timeout support was introduced in Python 3.3.
gpshead
added
docs
That is is None even when people ask to capture output but the process generated no output is a long standing API wart.
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11. |
|
GH-97686 is a backport of this pull request to the 3.11 branch. |
|
GH-97687 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 30, 2022
…nGH-97685) This documents the behavior that has always been the case since timeout support was introduced in Python 3.3. (cherry picked from commit b05dd79) Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 30, 2022
…nGH-97685) This documents the behavior that has always been the case since timeout support was introduced in Python 3.3. (cherry picked from commit b05dd79) Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
GH-97688 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 30, 2022
…nGH-97685) This documents the behavior that has always been the case since timeout support was introduced in Python 3.3. (cherry picked from commit b05dd79) Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington
added a commit
that referenced
this pull request
Sep 30, 2022
miss-islington
added a commit
that referenced
this pull request
Sep 30, 2022
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 2, 2022
…n#97685) This documents the behavior that has always been the case since timeout support was introduced in Python 3.3.
ambv
pushed a commit
that referenced
this pull request
Oct 4, 2022
hauntsaninja
added a commit
to hauntsaninja/typeshed
that referenced
this pull request
Oct 12, 2022
See python/cpython#97685 Thinking we'll go off of mypy_primer to decide if the union type here is acceptable or not. I'd like us to be able to type this, since the values being bytes can be surprising if you pass text=True
hauntsaninja
added a commit
to python/typeshed
that referenced
this pull request
Oct 12, 2022
See python/cpython#97685 The union type should be acceptable given python/cpython#87597 (comment). In general I'd like us to be able to type this, since these being bytes can be surprising if you pass text=True, but we'll see what mypy_primer says
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the behavior that has always been the case since timeout support was introduced in Python 3.3.