Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter excess entries #443

Merged
merged 11 commits into from
Apr 9, 2023
Merged

Filter excess entries #443

merged 11 commits into from
Apr 9, 2023

Commits on Mar 25, 2023

  1. Mark test as xfail as it's about to fail. Ref #442.

    @jaraco
    jaraco committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    cfd9b26 View commit details
    Browse the repository at this point in the history

  2. Add test capturing missed expectation. Ref #442.

    @jherland @jaraco
    jherland authored and jaraco committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    5e8260c View commit details
    Browse the repository at this point in the history

  3. 👹 Feed the hobgoblins (delint). 

    pep8 states that comments should be limited to 72 characters.
    @jaraco
    jaraco committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    da57855 View commit details
    Browse the repository at this point in the history

  4. Prefer all when asserting all. 

    ⚫ Fade to black.
    @jaraco
    jaraco committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    c867641 View commit details
    Browse the repository at this point in the history

  5. Filter non-identifiers from module names. Fixes #442.

    @jaraco
    jaraco committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    340cac3 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2023

  1. Relax assertion that all names in packages_distributions are identifi… 

    …ers.

The main contstraint here for an importable module is that it must not contain a module separator ('.'). Other names that contain dashes or spaces cannot be imported with the 'import' statement, but can be imported with 'importlib.import_module' or invoked with 'runpy'.
    @jaraco
    jaraco committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    a4e2a9b View commit details
    Browse the repository at this point in the history

  2. Expand test to include importable names that aren't identifiers and h… 

    …onor that expectation.
    @jaraco
    jaraco committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    7968a08 View commit details
    Browse the repository at this point in the history

  3. Capture expectation that 'dist-info' should not appear in inferred to… 

    …p-level names. Ref #442.
    @jaraco
    jaraco committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    1a831b6 View commit details
    Browse the repository at this point in the history

  4. Merge commit '1a831b6' into bugfix/442-excess-entries 

    Captures new failed expectation and verifies fix.
    @jaraco
    jaraco committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    2466939 View commit details
    Browse the repository at this point in the history

  5. Update changelog.

    @jaraco
    jaraco committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    4c02b18 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into bugfix/442-excess-entries

    @jaraco
    jaraco committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    64ae8f6 View commit details
    Browse the repository at this point in the history