Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeshed regression in 0.940 #12339

Closed
offbyone opened this issue Mar 12, 2022 · 5 comments · Fixed by #12340
Closed

Typeshed regression in 0.940 #12339

offbyone opened this issue Mar 12, 2022 · 5 comments · Fixed by #12340
Labels
bug mypy got something wrong

Comments

@offbyone
Copy link
Contributor

Bug Report

Typeshed had an issue with message.pyi that was identified in python/typeshed#7019:

typeshed/stdlib/email/message.pyi:13: error: Cannot determine type of "Any" (diff)

This was resolved in python/typeshed#7022 on Jan 24, sometime after the mypy 0.931 tag was cut.

mypy 0.940 apparently has the broken commit in typeshed, though. When running our regular CI tests, we picked up the 0.940 upgrade to mypy, which started failing our type checks by adding that additional output. You can see the pre- and post- upgrade tests here:

Your Environment

  • Mypy version used: 0.940
  • Mypy command-line flags: n/a
  • Mypy configuration options from mypy.ini (and other config files): n/a
  • Python version used: Observed on 3.8.12 and 3.10.0, but github stop tests after some fail in a group, so probably all 3.8+
  • Operating system and version: Ubuntu and macOS
@Tinche
Copy link
Contributor

Tinche commented Mar 14, 2022

This is also breaking the attrs test suite. Any chance this could be hotfixed? Feels kinda bad to tweak our test suite to account for this :(

hynek added a commit to python-attrs/attrs that referenced this issue Mar 14, 2022
It breaks test_mypy.

See also python/mypy#12339
offbyone added a commit to hamcrest/PyHamcrest that referenced this issue Mar 14, 2022
offbyone added a commit to offbyone/PyHamcrest that referenced this issue Mar 14, 2022
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Mar 14, 2022

cc @JukkaL, maybe we can cherry-pick #12340 and do a hotfix?

@JukkaL
Copy link
Collaborator

JukkaL commented Mar 14, 2022

@JelleZijlstra I'll do a 0.941 release with #12340.

@JukkaL
Copy link
Collaborator

JukkaL commented Mar 14, 2022

Mypy 0.941 is now out with the fix (#12340).

@Tinche
Copy link
Contributor

Tinche commented Mar 14, 2022

@JelleZijlstra @JukkaL thank you kindly for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mypy got something wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants