Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy tests are broken on Python 3.8.2 #8701

Closed
hauntsaninja opened this issue Apr 21, 2020 · 1 comment · Fixed by #8702
Closed

mypy tests are broken on Python 3.8.2 #8701

hauntsaninja opened this issue Apr 21, 2020 · 1 comment · Fixed by #8702

Comments

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Apr 21, 2020 •
edited
Loading

python/cpython#18491 changes col_offsets for some parenthesised expressions, of which mypy has a few in its test suite. This affects Python 3.9 as well. Note Travis currently seems to run with 3.8.0, I believe they update their Python images whenever they see fit.

https://bugs.python.org/issue40349
https://bugs.python.org/issue39474
hauntsaninja pushed a commit to hauntsaninja/mypy that referenced this issue Apr 21, 2020
mypy tests: sidestep AST col_offset changes
0214d9a 
Fixes python#8701
@hauntsaninja
Copy link
Collaborator Author

Here's a failure log: https://travis-ci.org/github/hauntsaninja/mypy/jobs/677588269
The simplest thing would just be to sidestep the issue by changing the relevant tests to not use parenthesised expressions.

hauntsaninja pushed a commit to hauntsaninja/mypy that referenced this issue Apr 21, 2020
mypy tests: sidestep AST col_offset changes
078e9d6 
Fixes python#8701
@hauntsaninja hauntsaninja mentioned this issue Apr 21, 2020
Merged
msullivan pushed a commit that referenced this issue Apr 23, 2020
@hauntsaninja
mypy tests: sidestep AST col_offset changes (#8702)
22c67da 
Fixes #8701

Co-authored-by: hauntsaninja <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mypy tests: sidestep AST col_offset changes hauntsaninja/mypy
1 participant
@hauntsaninja