Add --debug-serialize option
#14155
Merged
Add --debug-serialize option
#14155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run tree.serialize even if cache generation is disable. Useful for mypy_primer to detect serialize errors early.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
@ilevkivskyi Would you mind taking a quick look? |
ilevkivskyi
approved these changes
Dec 1, 2022
|
@ilevkivskyi Anything else that needs to be done here or can this be merged?
|
That one's already been completed: hauntsaninja/mypy_primer@ceecd71 |
ilevkivskyi
pushed a commit
that referenced
this pull request
Dec 19, 2022
Enable the `--debug-serialize` option to help catch issues during serialization which would normally be skipped by mypy_primer. Followup to #14155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
mypy_primersets--cache-dir=/dev/nullwhich disables cache generation. This can result in errors being missed which would normally come up duringtree.serialize(). Removing--cache-dir=/dev/nullisn't practical.This PR adds a new debug / test option
--debug-serializewhich runstree.serialize()even if cache generation is disabled to help detect serialize errors earlier.Refs
AssertionErrorwith nested TypeVar #14137cc: @hauntsaninja