Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in await inside comprehension outside function #14486

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Fix crash in await inside comprehension outside function #14486

merged 1 commit into from
Jan 21, 2023

Conversation

ilevkivskyi
Copy link
Member

Fixes #14345

I also decided to make this error a blocker, since it is essentially a syntax error. (And also a similar error for yield is a blocker).

@AlexWaygood AlexWaygood added the topic-async async, await, asyncio label Jan 21, 2023
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JukkaL
JukkaL approved these changes Jan 21, 2023
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JukkaL JukkaL merged commit eea917e into python:master Jan 21, 2023
@ilevkivskyi ilevkivskyi deleted the fix-await-crash branch January 21, 2023 14:42
@sjdemartini sjdemartini mentioned this pull request Feb 22, 2023
Closed
@sobolevn sobolevn mentioned this pull request Feb 28, 2023
Merged
JelleZijlstra pushed a commit that referenced this pull request Feb 28, 2023
@sobolevn
Add a separate error code for top level await (#14801)
494802f 
Now users can disable the first kind of error, but not the second kind
(which is always a syntax error).

Refs #14486
Closes #14763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Assignees
No one assigned
Labels
topic-async async, await, asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect asynchronous comprehension cause an internal error
3 participants
@ilevkivskyi @JukkaL @AlexWaygood