Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[used before def] correctly handle walrus operator #14646

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

ilinum
Copy link
Collaborator

@ilinum ilinum commented Feb 8, 2023

Fixes #14626.

I believe changing the way that we analyze call expression makes sense (first, we analyze the callee, then we analyze the arguments).

@ilinum ilinum mentioned this pull request Feb 8, 2023
17 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JukkaL JukkaL merged commit 6b56dc0 into python:master Feb 8, 2023
ilinum added a commit to ilinum/mypy that referenced this pull request Feb 8, 2023
Fixes python#14626.

I believe changing the way that we analyze call expression makes sense
(first, we analyze the callee, then we analyze the arguments).
@ilinum ilinum deleted the mypy/handle-walrus branch February 8, 2023 21:39
ilinum added a commit to ilinum/mypy that referenced this pull request Feb 8, 2023
Fixes python#14626.

I believe changing the way that we analyze call expression makes sense
(first, we analyze the callee, then we analyze the arguments).
ilinum added a commit that referenced this pull request Feb 9, 2023
#14654)

Fixes #14626.

I believe changing the way that we analyze call expression makes sense
(first, we analyze the callee, then we analyze the arguments).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reusing variable previously defined with walrus operator triggers used-before-def error
2 participants