[backport] [used before def] correctly handle walrus operator (#14646) #14654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python#14626. I believe changing the way that we analyze call expression makes sense (first, we analyze the callee, then we analyze the arguments).
hauntsaninja
approved these changes
Feb 8, 2023
|
I think you might need a commit like 1368338 to avoid confusing https://github.com/mypyc/mypy_mypyc-wheels when this is merged |
This comment was marked as outdated.
This comment was marked as outdated.
Thanks for pointing this out! Do you know what would happen if I did that? |
|
I think it's not the worst, but causes some confusion and some failures. I think the trigger wheel build tries to push a duplicate tag to the wheels repo and it fails (or maybe it overwrites the previous tag). I also seem to remember some issue when the wheels repo makes a release (to share the artifacts) if the release already exists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14626.
I believe changing the way that we analyze call expression makes sense (first, we analyze the callee, then we analyze the arguments).