Stubtest: verify stub methods or properties are decorated with @final if they are decorated with @final at runtime
#14951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l` if they are decorated with `@final` at runtime
sobolevn
reviewed
Mar 24, 2023
|
I also thing that overloads can easily be ignored at this stage. Because I don't think many users have final overloads in their runtime source code + separate stubs :) |
|
Thanks @sobolevn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements most of #14924. The only thing it doesn't implement is verification for overloaded methods decorated with
@final-- I tried working on that, but hit #14950.