Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash when serializing a type-ignored property setter #3493

Merged
merged 3 commits into from Jun 3, 2017
Merged

fix crash when serializing a type-ignored property setter #3493

merged 3 commits into from Jun 3, 2017

Commits on Jun 2, 2017

  1. fix crash when serializing a type-ignored property setter 

    This fixes the crash from python#3491. I wasn't able to reproduce the
crash in a test, even with '# flags: --incremental', so I'm
not adding any new tests. Do I need some special flags to make
tests write the cache?
    @JelleZijlstra
    JelleZijlstra committed Jun 2, 2017
    Copy the full SHA
    f00c1c6 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2017

  1. Add tests 

    Turns out the cache isn't written if there is any error,
and I had a reveal_type which counts as an error.

The change fixes both bugs from the original issue:
- Without --disallow-untyped-defs, it no longer crashes during
  cache serialization.
- With --disallow-untyped-defs, it no longer produces a spurious
  error because "self" doesn't have an annotation.
    @JelleZijlstra
    JelleZijlstra committed Jun 3, 2017
    Copy the full SHA
    81478f4 View commit details
    Browse the repository at this point in the history

  2. Conform to PEP 8.

    @gvanrossum
    gvanrossum committed Jun 3, 2017
    Copy the full SHA
    480445b View commit details
    Browse the repository at this point in the history