Allow nonliteral tuple indexing #3514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Jun 9, 2017
mypy/checkexpr.py
Outdated
| def nonliteral_tuple_index_helper(self, left_type: TupleType, index: Expression) -> Type: | ||
| index_type = self.accept(index) | ||
| expected_type = UnionType.make_union([self.named_type('builtins.int'), | ||
| self.named_type('builtins.slice')]) |
There was a problem hiding this comment.
Indent by one more space. (Was it vim or you that got this wrong?
There was a problem hiding this comment.
Oops! That was me. I forgot to put the arguments in a list originally and failed to reindent after doing so.
Thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #899. Allows indexing and slicing tuples with nonliteral values: returns a Union of all tuple item types.