New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen type to Any when isinstance(..., Any) is True #3751

Merged
merged 3 commits into from Nov 22, 2017

Conversation

Projects
None yet
3 participants
@miedzinski
Contributor

miedzinski commented Jul 20, 2017

Fixes #3474.

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Sep 8, 2017

Collaborator

This appeared again, are you still working on this PR?

Collaborator

ilevkivskyi commented Sep 8, 2017

This appeared again, are you still working on this PR?

@JukkaL

This comment has been minimized.

Show comment
Hide comment
@JukkaL

JukkaL Nov 15, 2017

Collaborator

@miedzinski Are you interested in finishing this PR?

Collaborator

JukkaL commented Nov 15, 2017

@miedzinski Are you interested in finishing this PR?

@miedzinski

This comment has been minimized.

Show comment
Hide comment
@miedzinski

miedzinski Nov 21, 2017

Contributor

@JukkaL Yes, I am. I have merged master into my branch and will look into this weekend.

Contributor

miedzinski commented Nov 21, 2017

@JukkaL Yes, I am. I have merged master into my branch and will look into this weekend.

@miedzinski

This comment has been minimized.

Show comment
Hide comment
@miedzinski

miedzinski Nov 22, 2017

Contributor

@ilevkivskyi Do you have any ideas for more test cases?

Contributor

miedzinski commented Nov 22, 2017

@ilevkivskyi Do you have any ideas for more test cases?

@ilevkivskyi

LGTM, thanks!

@ilevkivskyi ilevkivskyi merged commit 0bbf714 into python:master Nov 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment