Widen type to Any when isinstance(..., Any) is True #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Aug 2, 2017
test-data/unit/check-isinstance.test
Outdated
| @@ -1770,3 +1770,13 @@ def narrow_any_to_str_then_reassign_to_int() -> None: | |||
| reveal_type(v) # E: Revealed type is 'Any' | |||
|
|
|||
| [builtins fixtures/isinstance.pyi] | |||
|
|
|||
| [case testIsinstanceWidensWithAnyArg] | |||
There was a problem hiding this comment.
I think this is a good fix, but could you please add few more tests:
- With an error and
# type: ignore - With an "un-imported"
Any - With an initial type that is not a union
|
This appeared again, are you still working on this PR? |
|
@miedzinski Are you interested in finishing this PR? |
|
@JukkaL Yes, I am. I have merged master into my branch and will look into this weekend. |
|
@ilevkivskyi Do you have any ideas for more test cases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3474.