Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a shared incremental cache for pythoneval tests #5114

Merged
merged 1 commit into from
May 26, 2018

Conversation

ethanhs
Copy link
Collaborator

@ethanhs ethanhs commented May 26, 2018

This causes the tests to run much faster! On my machine without incremental they take 52 seconds. With the incremental cache, they take only 22 seconds.

This fixes #1412.

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like a clean solution to me.

@ilevkivskyi ilevkivskyi merged commit d3b32b7 into python:master May 26, 2018
@ethanhs ethanhs deleted the increval branch January 31, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use incremental mode in python evaluation test cases
2 participants