Drop support for Python 3.3 #5248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
commented
Jun 20, 2018
| @@ -175,7 +176,7 @@ def add_stubs(driver: Driver) -> None: | |||
|
|
|||
| modules = {'typing'} | |||
| # TODO: This should also test Python 2, and pass pyversion accordingly. | |||
| for version in ["2and3", "3", "3.3", "3.4", "3.5"]: | |||
| for version in ["2and3", "3", "3.5"]: | |||
There was a problem hiding this comment.
I would have added "3.6" and "3.7", but that causes the tests to fail with the following:
FAILURE #3 check stubs
mypy: can't find module 'contextvars'
This should also probably use a glob, so adding directories is not forgotten in the future.
There was a problem hiding this comment.
I think @ethanhs was working recently on fixing this code.
JelleZijlstra
approved these changes
Jun 20, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also python/typeshed#2258 and python/typeshed#2260.