New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report "function does not return a value" in dynamic functions #5683

Merged
merged 2 commits into from Sep 26, 2018

Conversation

Projects
None yet
3 participants
@msullivan
Collaborator

msullivan commented Sep 26, 2018

Fixes a regression (that causes trouble in internal codebases) introduced in #5663.

@msullivan msullivan requested review from gvanrossum and ilevkivskyi Sep 26, 2018

@ilevkivskyi

Thanks, you are faster than me :-)

pass
def lol():
1+'uh'

This comment has been minimized.

@ilevkivskyi

ilevkivskyi Sep 26, 2018

Collaborator

Maybe add spaces around + (totally up to you).

This comment has been minimized.

@msullivan

msullivan Sep 26, 2018

Collaborator

Oh actually this should just not be there at all

@msullivan msullivan merged commit 2e2fe30 into master Sep 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msullivan msullivan deleted the fix-none-errors branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment