New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stubgen to output async def and coroutine decorators #5845

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@bryanforbes
Copy link
Contributor

bryanforbes commented Oct 27, 2018

Fixes #5844

@JelleZijlstra
Copy link
Collaborator

JelleZijlstra left a comment

Mostly looks good, thanks for the thorough tests.

Show resolved Hide resolved mypy/stubgen.py Outdated
@bryanforbes

This comment has been minimized.

Copy link
Contributor

bryanforbes commented Oct 29, 2018

I have addressed your feedback. Thank you!

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

ilevkivskyi commented Nov 25, 2018

Sorry for a ping, @JelleZijlstra are you happy with the updates?

@JelleZijlstra

This comment has been minimized.

Copy link
Collaborator

JelleZijlstra commented Nov 26, 2018

Looks good to me, sorry for the delay.

@ilevkivskyi ilevkivskyi merged commit 1a9e280 into python:master Nov 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

ilevkivskyi commented Nov 26, 2018

Thanks for a PR @bryanforbes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment