Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stubgen to output async def and coroutine decorators #5845

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Update stubgen to output async def and coroutine decorators #5845

merged 2 commits into from
Nov 26, 2018

Conversation

bryanforbes
Copy link
Contributor

Fixes #5844

JelleZijlstra
JelleZijlstra reviewed Oct 27, 2018
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, thanks for the thorough tests.

mypy/stubgen.py Outdated Show resolved Hide resolved
@bryanforbes
Copy link
Contributor Author

I have addressed your feedback. Thank you!

@ilevkivskyi
Copy link
Member

Sorry for a ping, @JelleZijlstra are you happy with the updates?

@JelleZijlstra
Copy link
Member

Looks good to me, sorry for the delay.

@ilevkivskyi ilevkivskyi merged commit 1a9e280 into python:master Nov 26, 2018
@ilevkivskyi
Copy link
Member

Thanks for a PR @bryanforbes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanforbes @ilevkivskyi @JelleZijlstra