Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to skip mtime checks on cache files #6391

Merged
merged 1 commit into from Feb 14, 2019
Merged

Add a flag to skip mtime checks on cache files #6391

merged 1 commit into from Feb 14, 2019

Commits on Feb 13, 2019

  1. Add a flag to skip mtime checks on cache files 

    When using an externally generated sqlite cache in daemon mode,
we should already trust that the cache is valid, and all the mtime
checks are surprisingly slow. (About 1s on S on my MBP.)

Allow skipping these.

An alternative I considered was to just always skip them when using
a sqlite cache, but I think we'd need to be more careful about
when we commit if we want to guarentee cache integrity.
    @msullivan
    msullivan committed Feb 13, 2019
    Copy the full SHA
    d073279 View commit details
    Browse the repository at this point in the history