Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify client on all dmypy crashes #7593

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Notify client on all dmypy crashes #7593

merged 1 commit into from
Oct 1, 2019

Conversation

msullivan
Copy link
Collaborator

This is done by setting the raise_exceptions option, which will cause
the exception to continue to be propagated.
Closes #4804.

Tested by introducing a crash in the parser and verifying the message
came through.

This is done by setting the raise_exceptions option, which will cause
the exception to continue to be propagated.
Closes #4804.

Tested by introducing a crash in the parser and verifying the message
came through.
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!

@msullivan msullivan merged commit 583b99e into master Oct 1, 2019
@msullivan msullivan deleted the dmypy-crash branch October 1, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daemon crashes that report_internal_error don't notify client
2 participants