Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for subclasses of bytes overriding __str__ #8222

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix false positive for subclasses of bytes overriding __str__ #8222

merged 1 commit into from
Jan 9, 2020

Conversation

hauntsaninja
Copy link
Collaborator

Fixes #8180

ethanhs
ethanhs approved these changes Jan 1, 2020
View reviewed changes
Copy link
Collaborator

@ethanhs ethanhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@msullivan msullivan merged commit f709429 into python:master Jan 9, 2020
@hauntsaninja hauntsaninja deleted the 8180 branch January 9, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanhs ethanhs ethanhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious error formatting bytes subclass with overridden __str__
3 participants
@hauntsaninja @ethanhs @msullivan