Use absolute path when checking source duplication error #9059
Conversation
mypy/build.py
Outdated
| @@ -2754,7 +2754,7 @@ def load_graph(sources: List[BuildSource], manager: BuildManager, | |||
|
|
|||
| # Note: Running this each time could be slow in the daemon. If it's a problem, we | |||
| # can do more work to maintain this incrementally. | |||
| seen_files = {st.path: st for st in graph.values() if st.path} | |||
| seen_files = {os.path.abspath(st.path): st for st in graph.values() if st.path} | |||
There was a problem hiding this comment.
This code is very performance critical, and os.path.abspath is too slow to call here since it can make a syscall. We'd need a way to do this without introducing much overhead (graph may have 100k+ values).
There was a problem hiding this comment.
Thank you for your review!
I understand. Then, how about looking up both absolute path and relative path of newst.path in seen_files at this part:
Lines 2805 to 2807 in d9c5c65
There was a problem hiding this comment.
I have updated my PR: c1f7d1e
Could you please check if it is reasonable?
There was a problem hiding this comment.
How about going back to the original approach, but adding an abspath field to State that is computed in State's constructor, instead of recomputing it on each load_graph?
(In the daemon, load_graph gets called a lot on a big graph but with only a few sources changed. We do some things that are linear in the graph but we feel bad about it and try to make sure that they aren't expensive things.)
There was a problem hiding this comment.
OK actually I just went and did that thing. Thank you!
msullivan
force-pushed
the
fix_source_duplicate_check
branch
from
03f4b42
to
b511aea
Compare
closes #9058
I updated both
seen_filesandnewstto use an absolute path to fix the problem.