PEP 573: Remove DefiningTypeFromSlotFunc, split public/private API #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the MRO walker, PyType_DefiningTypeFromSlotFunc, as it was found it can give wrong results when a type's special methods are changed (which can be done from Python code). Solving the issue is deferred to a future PEP (and/or perhaps a private CPython function). - Split public C-API from CPython implementation details. It turns out that alternate C-API implementations have grown more important since 2016, if only for experimenting with possible optimizations. - Add potentially confusing terms "Defining Class" and "C-API" to the terminology section. - Mention that ht_module i not inherited by subclasses. - Remove modules to be ported initially: zipimport (since rewritten in Python), _io and _cvs (need module state from slot methods).
ncoghlan
reviewed
Jan 15, 2020
pep-0573.rst
Outdated
| from slot methods (``nb_add``, etc) remains slower than accessing that state | ||
| from other extension methods. Standard caching techniques can be used to speed | ||
| up subsequent access. | ||
| remaining concerns. In particular, at access to the module state |
pep-0573.rst
Outdated
| ``True.__floor__`` and ``int.__repr__``. | ||
|
|
||
| (For methods defined in Python, where unbound methods are plain functions, | ||
| the term is somewhat fuzzy. This PEP deals with methods defined in C |
There was a problem hiding this comment.
It isn't normally fuzzy in Python - it's what ends up in the __class__ closure cell.
|
Thanks!
I expanded the existing note in "Possible Future Extensions", hopefully that's OK even though it's something we really want to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found it can give wrong results when a type's special methods are
changed (which can be done from Python code).
Solving the issue is deferred to a future PEP (and/or perhaps a
private CPython function).
that alternate C-API implementations have grown more important
since 2016, if only for experimenting with possible optimizations.
terminology section.
in Python), _io and _cvs (need module state from slot methods).
cc @Dormouse759