Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: Update outdated Python-Version on still-Draft PEPs #2756

Merged

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented Aug 10, 2022

Now that Python 3.11 is in its RC phase, the still-Draft PEPs targeting it or an earlier version can't make the cut, so I've checked each PEP carefully, as well as their associated discussion threads and the Steering Council repo, and bumped/dropped their Python-Versions accordingly.

Authors, please either let us know that a version bump is okay, or otherwise let us know what you'd like to do about your PEP (e.g. a later target version, removing the version entirely and Deferring/Withdrawing it, etc.); I'll leave this open for ≈two weeks, unless we hear from everyone before then, to ensure everyone has a chance to see this. Thanks!

Two PEPs were exceptions to just bumping the version:

  • PEP 603 (PEP-603) appears to be inactive, as there haven't been meaningful changes or much discussion activity for several years. @1st1 , I haven't done that here (I just dropped the outdated Python-Version header for now, which still read 3.9), but do you mind if we at least mark it Deferred, would you like to formally Withdraw it, or would you rather it be updated to retarget 3.12?

    @1st1 responded on the PEP's discussion thread; I'll just leave things as they are for now (just dropping the version), unless @pablogsal wants to take over and updates the PEP, in which case I can drop the changes here.

  • PEP 674 (PEP-674) appears to have been not accepted in its current form, with changes requested. @vstinner how would you like to move forward here? Target it on 3.12? 3.14? Mark it as Deferred? Something else? For now I just dropped the outdated header and left everything else as it is.

Also, I marked the two latest release PEPs as Active rather than Draft, since they are Informational PEPs and each of their formal release cycles has been going on for quite some time now, and opportunistically added a few missing Discussions-To that I found in the course of my research on each PR.

Originally discussed in #2755 (comment)

pep-0689.rst Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

PEP 674 (...) how would you like to move forward here?

I'm considering writing down my long term plan for the C API which explains the rationale for all C API changes and why they should be done as soon as possible.

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@CAM-Gerlach
Copy link
Member Author

I'm considering writing down my long term plan for the C API which explains the rationale for all C API changes and why they should be done as soon as possible.

Looking forward to that! As for PEP 674, do you want it retargeted it on Python-Version: 3.12, then? As it stands, I've just dropped the outdated version header and otherwise left everything as-is.

Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye, bumping 558 is correct.

@CAM-Gerlach
Copy link
Member Author

Its been >2 weeks, so going ahead with this...

@CAM-Gerlach CAM-Gerlach merged commit f613ad8 into python:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lint Linter-related work and linting fixes on PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants