Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 730: More revisions and clarifications #3529

Merged
merged 4 commits into from Nov 16, 2023

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Nov 9, 2023

A second pass of revisions and clarifications on PEP 730, adding Tier 3 iOS support.

  • Adds an explicit mention of iPadOS

  • Proposes linking binary modules with libPython to avoid a deprecated compiler option

  • Proposes dropping static libPython.a builds as a supported output format

  • Clarifies the compilation process and the relationship between the configure/make/make install build and the useable artefacts.

  • Change is either:

    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)


馃摎 Documentation preview 馃摎: https://pep-previews--3529.org.readthedocs.build/

peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
freakboy3742 and others added 2 commits November 10, 2023 11:13
peps/pep-0730.rst Outdated Show resolved Hide resolved
peps/pep-0730.rst Outdated Show resolved Hide resolved
Copy link
Member

@mhsmith mhsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have access to resolve discussions in this repository, but all my comments have now been addressed.

@freakboy3742
Copy link
Contributor Author

@hugovk @ned-deily Checking in on this - is there anything outstanding preventing a merge, or did this just fall through the review cracks?

@ned-deily ned-deily merged commit c0870de into python:main Nov 16, 2023
6 checks passed
@freakboy3742 freakboy3742 deleted the pep-730-update-2 branch November 16, 2023 01:14
@ned-deily
Copy link
Member

is there anything outstanding preventing a merge, or did this just fall through the review cracks?

The latter, sorry!

@mhsmith
Copy link
Member

mhsmith commented Dec 6, 2023

@ned-deily: I don't think we've been properly introduced, but I'm the Android expert on the BeeWare team, and I'm planning to create an Android equivalent of this PEP. Is it OK if I list you as the sponsor?

@encukou
Copy link
Member

encukou commented Dec 6, 2023

In case Ned wants to stay on the Apple side of things, and we don't find a core dev familiar with Android/Java native integration, I'd be happy to sponsor that PEP.

@ned-deily
Copy link
Member

Hello, @mhsmith! Consider yourself properly introduced.

I'm not just at home in the Apple side of things but I am a stranger in the world of Android. So, having no special knowledge or any experience with Android, I would prefer if another core developer takes on the role of PEP sponsor for that. Thanks, @encukou!

@mhsmith
Copy link
Member

mhsmith commented Dec 7, 2023

Thanks very much; I should have a first draft ready next week. There won't actually be much Java involved 鈥撀燼s far as Python is concerned, Android is mostly just a variant of Linux.

@encukou
Copy link
Member

encukou commented Dec 7, 2023

next week

So soon! That's great!
I can't promise my availability for the rest of the year. I should still be here next week, and I'll definitely be here in January.
In case I don't manage to review the draft, you can post it to Discourse without me.

@mhsmith
Copy link
Member

mhsmith commented Dec 14, 2023

The Android PEP is now up for review at #3586.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants