Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 738: Adding Android as a supported platform #3586

Merged
merged 8 commits into from Jan 12, 2024

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Dec 12, 2023

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--3586.org.readthedocs.build/pep-0738/

@mhsmith mhsmith requested a review from a team as a code owner December 12, 2023 23:09
Copy link

cpython-cla-bot bot commented Dec 12, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@mhsmith
Copy link
Member Author

mhsmith commented Dec 12, 2023

@encukou and @freakboy3742: Your comments would be welcome.

peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
@Kacper-OS
Copy link

I like this idea

mhsmith and others added 2 commits December 13, 2023 20:34
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
peps/pep-0738.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhsmith. This is off to a wonderful start and is very thorough.

peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
peps/pep-0738.rst Outdated Show resolved Hide resolved
@encukou
Copy link
Member

encukou commented Dec 14, 2023

Hello,
As the sponsor, I apologize for not giving clear guidance. I expected Malcolm would share the draft with me privately first, so we'd get the details ironed out and the process straight. But I gave a note of what to do in case I wasn't available, which was, in hindsight, too brief.

The first round of discussions around an idea usually happens before a PEP number is assigned yet; the PEP is then written to discuss concrete (and specifically worded) proposal.
Here, the idea is sound and experts have been hammering out the details for years, so perhaps a PR -- and PEP number assignment -- is a good first step.
Regardless, the proposed PEP number should not be used before it's assigned. But since it has been used, I'd like to kindly ask that PEP editors do pick 738 :)

@mhsmith
Copy link
Member Author

mhsmith commented Dec 14, 2023

@encukou: Thanks, and sorry for the misunderstanding.

@freakboy3742
Copy link
Contributor

Hello, As the sponsor, I apologize for not giving clear guidance.

Apologies on my part, as well - @mhsmith was following what I did with PEP 730, which didn't go through this "pre-release" process.

@encukou
Copy link
Member

encukou commented Dec 18, 2023

@mhsmith, it's OK to leave any suggestions to a future revision, especially ones asking for significant rewording, expanding, or adding new sections.
That doesn't mean those comments aren't welcome, of course! Definitely put them on your TODO list. But you can focus this PR on getting an initial version of the PEP published.

@freakboy3742 Yeah, the sprint allowed a higher-throughput process :)
No harm done, I hope.

@mhsmith
Copy link
Member Author

mhsmith commented Dec 20, 2023

@encukou: Thanks, I'll do that.

@mhsmith
Copy link
Member Author

mhsmith commented Dec 22, 2023

Main changes:

  • Added more justification for the choice of target Android versions and architectures.
  • Gathered coverage of development tools into a new section, and added information about NDK versions.
  • Added a deliverable for documentation of how to use the embeddable package.

@freakboy3742, @willingc, @encukou: I think this addresses all of your comments, so please resolve your conversations or comment more as appropriate. I know we're getting into the holiday season now, so take as long as you like.

There are some other open discussions on the Discourse thread, but I'll leave those until the next draft.

@mhsmith
Copy link
Member Author

mhsmith commented Jan 11, 2024

@willingc, @encukou: Happy new year! Please resolve your open conversations when you get a chance, as I think this PR is ready to merge. I'll then look into the other points that were raised on the Discourse thread, and create a separate PR with a second draft.

@willingc
Copy link
Contributor

@willingc, @encukou: Happy new year! Please resolve your open conversations when you get a chance, as I think this PR is ready to merge. I'll then look into the other points that were raised on the Discourse thread, and create a separate PR with a second draft.

@mhsmith Done. Thanks so much for getting this PEP done 🎉

@encukou
Copy link
Member

encukou commented Jan 12, 2024

Thanks for the ping!

@encukou encukou dismissed freakboy3742’s stale review January 12, 2024 09:38

All review discussions are marked resolved by the reviewer

@encukou encukou merged commit 2cbb99c into python:main Jan 12, 2024
6 checks passed
@encukou
Copy link
Member

encukou commented Jan 12, 2024

Congratulations, it's a PEP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants