Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 639: Incorporate the latest discussion feedback #3866

Merged
merged 6 commits into from
Jul 25, 2024
Merged

PEP 639: Incorporate the latest discussion feedback #3866

merged 6 commits into from
Jul 25, 2024

Conversation

befeleme
Copy link
Contributor

@befeleme befeleme commented Jul 17, 2024 •
edited
Loading

Included changes:

  • remove the default glob values expected from build tools to match license-files (build backends can still define them if they wish, the standard just doesn't make any recommendation about them)
  • change the error policy around deprecated license classifiers - tools MAY -- not MUST -- raise an error if they encounter them
  • flatten the value of license-files key - expect glob patterns, specify the glob characters supported
  • rework Rejected ideas to reflect the above changes, ideally reducing them in size during the process

📚 Documentation preview 📚: https://pep-previews--3866.org.readthedocs.build/

@befeleme befeleme changed the title [WIP] PEP 639: Incorporate the latest discussion feedback PEP 639: Incorporate the latest discussion feedback Jul 17, 2024
@befeleme befeleme marked this pull request as ready for review July 17, 2024 14:51
@befeleme befeleme requested review from CAM-Gerlach and a team as code owners July 17, 2024 14:51
hroncok
hroncok reviewed Jul 25, 2024
View reviewed changes
peps/pep-0639.rst Outdated Show resolved Hide resolved
@befeleme @hroncok
Update peps/pep-0639.rst
dddf688 
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@brettcannon brettcannon merged commit db2a96f into python:main Jul 25, 2024
6 checks passed
@befeleme befeleme deleted the nodefaults branch July 26, 2024 07:59
@befeleme befeleme restored the nodefaults branch July 26, 2024 07:59
@befeleme befeleme deleted the nodefaults branch July 26, 2024 07:59
pauleveritt pushed a commit to pauleveritt/peps that referenced this pull request Aug 6, 2024
@befeleme @hroncok
PEP 639: Incorporate the latest discussion feedback (python#3866)
b7bf1ca 
* Remove the requirement of license-files defaults

* Cover all rejected subkeysideas in one paragraph

* Change the deprecation policy around classifiers

* Flatten the value of the license-files key, only globs are specified

* Update the Rejected ideas to match the current license-files proposal

---------

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
jimbaker added a commit to jimbaker/peps that referenced this pull request Aug 7, 2024
@pauleveritt @jimbaker
@lysnikolaou @davidfstr @warsaw @hugovk @erlend-aasland @AA-Turner @Yhg1s @woodruffw @JelleZijlstra @carljm @Rnbsov @Mariatta @brettcannon @willingc @encukou @vstinner @befeleme @hroncok
Last two comments from Carol (#6)
fe012b6 
* Include three comments from @Carreau (drop two bullets, *args in example, explain *args.)

* Lambda-wrapped expressions use annotation scope

* Clarify use of annotation scope

* Mention what happens to named unicodes followed by text

* Use DecodedConcrete in assertion

* Rewrite why annotation scope is needed (#4)

* Rewrite why annotation scope is needed

* Minor copyediting

* PEP 747: Fix rules related to UnionType (T1 | T2). Contrast TypeExpr with TypeAlias. Apply other feedback. (python#3856)

* PEP 694: Fix typo (python#3859)

* PEP 2026: Update following discussion (python#3860)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

* PEP 101: Remove outdated info and add new info (python#3863)

* PEP 101: Remove outdated info

* PEP 101: Update make command for running tests

* PEP 101: Replace '#python-dev and/or python-committers' with 'Discord and/or Discourse

* PEP 101: Add Hugo as 3.14 RM

* PEP 101: Add to PSRT

* PEP 11: Add Russell as an iOS contact (python#3865)

* Meta: Document the PEPs API (python#3864)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

* PEP 719: Update for today's release of 3.13.0b4 (python#3868)

* PEP 740: Mark as Provisional (python#3848)

Signed-off-by: William Woodruff <william@yossarian.net>

* PEP 749: Add section on metaclasses (python#3847)

Co-authored-by: Carl Meyer <carl@oddbird.net>

* PEP 8: Update a Wikipedia link (python#3552)

* PEP 635: Minor typo fix in code sample (python#3871)

Looks like an unclosed f-string.

* PEP 751: A file format to list Python dependencies for installation reproducibility (python#3870)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>

* PEP 743: Rewrite to hide (soft-)deprecated API (pythonGH-3869)

Co-authored-by: Victor Stinner <vstinner@python.org>

* PEP 751: Add Discussions-To and Post-History (python#3872)

* PEP 639: Incorporate the latest discussion feedback (python#3866)

* Remove the requirement of license-files defaults

* Cover all rejected subkeysideas in one paragraph

* Change the deprecation policy around classifiers

* Flatten the value of the license-files key, only globs are specified

* Update the Rejected ideas to match the current license-files proposal

---------

Co-authored-by: Miro Hrončok <miro@hroncok.cz>

* PEP 715: clarify what `[package.tool]` is (python#3873)

* PEP 665: Superseded-By: 751 (python#3875)

* PEP 751: update based on feedback (python#3877)

* PEP 751: update based on feedback

* Fix a section underline

* Include three comments from @Carreau (drop two bullets, *args in example, explain *args.)

* From Carol, move the point about import to the following paragraph.

* Per Carol: Remove paragraph about lifecycles as that is about *a* DSL, not DSLs in general.

---------

Signed-off-by: William Woodruff <william@yossarian.net>
Co-authored-by: pauleveritt <paul.everitt@jetbrains.com>
Co-authored-by: Jim Baker <jim.baker@python.org>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: David Foster <david@dafoster.net>
Co-authored-by: Barry Warsaw <barry@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: T. Wouters <thomas@python.org>
Co-authored-by: William Woodruff <william@yossarian.net>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Carl Meyer <carl@oddbird.net>
Co-authored-by: Lavrentiy Rubtsov <rnbsov@gmail.com>
Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Karolina Surma <33810531+befeleme@users.noreply.github.com>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hroncok hroncok hroncok left review comments

@brettcannon brettcannon brettcannon approved these changes

@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach CAM-Gerlach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@befeleme @brettcannon @hroncok