Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-History should include dates of postings to python-ideas #441

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

phdru
Copy link
Contributor

@phdru phdru commented Oct 27, 2017

@warsaw
Copy link
Member

warsaw commented Oct 27, 2017

We had a discussion on python-dev about this (buried in the PEP 517 thread), and Guido expressed the opinion of dropping python-list and adding python-ideas. I agree with that, although it's a process change and will require notification to the relevant mailing lists.

Can you please make that change to this PR?

@warsaw warsaw self-requested a review October 27, 2017 15:29
pep-0001.txt Outdated
@@ -379,7 +379,8 @@ optional and are described below. All other headers are required. ::
* Requires: <pep numbers>
Created: <date created on, in dd-mmm-yyyy format>
* Python-Version: <version number>
Post-History: <dates of postings to python-list and python-dev>
Post-History: <dates of postings to python-list, python-dev
and/or python-ideas>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now say dates of postings to python-ideas and/or python-dev.

pep-0001.txt Outdated
headers should be in dd-mmm-yyyy format, e.g. 14-Aug-2001.
versions of the PEP are posted to python-list, python-dev and/or
python-ideas. Both headers should be in dd-mmm-yyyy format, e.g.
14-Aug-2001.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also now say posted to python-ideas and/or python-dev.

@phdru
Copy link
Contributor Author

phdru commented Oct 27, 2017

@warsaw Done.

pep-0001.txt Outdated
@@ -379,7 +379,7 @@ optional and are described below. All other headers are required. ::
* Requires: <pep numbers>
Created: <date created on, in dd-mmm-yyyy format>
* Python-Version: <version number>
Post-History: <dates of postings to python-list and python-dev>
Post-History: <dates of postings to python-dev and/or python-ideas>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this needs to be python-ideas and/or python-dev. The reasoning is that python-dev must always be included but python-ideas is optional.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment below.

@phdru
Copy link
Contributor Author

phdru commented Oct 27, 2017

@warsaw Done.

Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@warsaw warsaw merged commit 9cd870e into python:master Oct 27, 2017
@phdru phdru deleted the pep1-posthistory branch October 27, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants