-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"func_annotations" -> " __annotations__" #628
Conversation
Since we ended up with `__annotations__`, it would be much less confusing if this used it instead of referring to a property that does not exist.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
Signed! |
Hi @jseakle. Unfortunately, your username does not appear to be attached to a bugs.python.org user, so our bot (nor us meaty folk) can't tell whether you've signed or not. Could you please make sure you have an account on bugs.python.org with |
Hi Zachary,
I received a similar email from betsy@python.org a few days ago. My
response to her is below, I haven't gotten a reply yet.
…----
Hi Betsy,
I did register, I and I received a confirmation email – however, the link
to activate my account didn't work, leading instead to the homepage with
this banner:
Invalid URL scheme in homepage URL
So, I tried to activate by replying to the email instead, which it also
listed as an option. However, I see that that didn't work either. I'm not
sure how to proceed from here, any suggestions?
Thanks,
Jake
On Fri, Apr 27, 2018 at 1:36 AM, Zachary Ware ***@***.***> wrote:
Hi @jseakle <https://github.com/jseakle>. Unfortunately, your username
does not appear to be attached to a bugs.python.org user, so our bot (nor
us meaty folk) can't tell whether you've signed or not. Could you please
make sure you have an account on bugs.python.org with jseakle in the
GitHub Name field of your profile? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#628 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAIyIcDnenZGjglhqyQBjTVH-sljAfk3ks5tsq5VgaJpZM4TgQsD>
.
--
A warb degombs the brangy. Your gitch zanks and leils the warb.
|
@jseakle did you try the Google or Launchpad login options? If so then just try again by creating an account the old-fashioned way. |
ah, ok, that seems to have worked. I didn't realize i'd be able to edit my
username to match the CLA.
…On Fri, Apr 27, 2018 at 11:42 AM Brett Cannon ***@***.***> wrote:
@jseakle <https://github.com/jseakle> did you try the Google or Launchpad
login options? If so then just try again by creating an account the
old-fashioned way.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#628 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAIyIannYd25_wyjpqPrQnZ_UhoX6JpAks5tszxwgaJpZM4TgQsD>
.
--
A warb degombs the brangy. Your gitch zanks and leils the warb.
|
I believe I managed to set up my account correctly now – can someone verify, and remove the "CLA not signed" tag if everything's in order? |
@jseakle double-check with Betsy that they processed your CLA in the end. |
Since we ended up with
__annotations__
, it would be much less confusing if this used it instead of referring to a property that does not exist.