Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"func_annotations" -> " __annotations__" #628

Merged
merged 2 commits into from
May 16, 2018
Merged

Conversation

jseakle
Copy link
Contributor

@jseakle jseakle commented Apr 23, 2018

Since we ended up with __annotations__, it would be much less confusing if this used it instead of referring to a property that does not exist.

Since we ended up with `__annotations__`, it would be much less confusing if this used it instead of referring to a property that does not exist.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@jseakle
Copy link
Contributor Author

jseakle commented Apr 23, 2018

Signed!

@zware
Copy link
Member

zware commented Apr 27, 2018

Hi @jseakle. Unfortunately, your username does not appear to be attached to a bugs.python.org user, so our bot (nor us meaty folk) can't tell whether you've signed or not. Could you please make sure you have an account on bugs.python.org with jseakle in the GitHub Name field of your profile? Thanks!

@jseakle
Copy link
Contributor Author

jseakle commented Apr 27, 2018 via email

@brettcannon
Copy link
Member

@jseakle did you try the Google or Launchpad login options? If so then just try again by creating an account the old-fashioned way.

@jseakle
Copy link
Contributor Author

jseakle commented Apr 27, 2018 via email

@jseakle
Copy link
Contributor Author

jseakle commented Apr 30, 2018

I believe I managed to set up my account correctly now – can someone verify, and remove the "CLA not signed" tag if everything's in order?

@brettcannon
Copy link
Member

@jseakle double-check with Betsy that they processed your CLA in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants