Fix TypeError error when expires is set to None.

Closes #814
python · Aug 18, 2015 · 2b6c013 · 2b6c013
1 parent 2ea3448
commit 2b6c013
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/jobs/models.py b/jobs/models.py
@@ -213,9 +213,8 @@ def is_new(self):
     def visible(self):
         if self.status != self.STATUS_APPROVED:
             return False
-        if self.expires <= timezone.now():
+        if self.expires and self.expires <= timezone.now():
             return False
-
         return True
 
     @property

diff --git a/jobs/tests/test_models.py b/jobs/tests/test_models.py
@@ -133,3 +133,9 @@ def test_display_location(self):
 
         job2 = self.create_job(region='')
         self.assertEqual(job2.display_location, 'Memphis, USA')
+
+    def test_expires_none(self):
+        # see issue #814
+        j1 = factories.ApprovedJobFactory()
+        j1.expires = None
+        self.assertTrue(j1.visible)
diff --git a/pydotorg/settings/local.py b/pydotorg/settings/local.py
@@ -1,7 +1,9 @@
 from .base import *
 
-DEBUG = True
-TEMPLATE_DEBUG = True
+DEBUG = TEMPLATE_DEBUG = True
+
+ALLOWED_HOSTS = ['*']
+
 PYTHON_ORG_CONTENT_SVN_PATH='/Users/flavio/working_copies/beta.python.org/build/data'
 
 HAYSTACK_CONNECTIONS = {