NoReverseMatch for usernames containing +

[berkerpeksag]

Saw this at Sentry: https://app.getsentry.com/python-software-foundation/production/group/62615414/

The question is should we allow + in username and slug (slug is acvtually the username field here) fields (see https://github.com/python/pythondotorg/blob/master/users/urls.py#L17), or should be raise a ValidationError in https://github.com/python/pythondotorg/blob/master/users/forms.py#L9?

[berkerpeksag]

Full message (username redacted):

NoReverseMatch Root Cause
Reverse for 'user_detail' with arguments '()' and keyword arguments '{'slug': 'foo+--+'}' not found. 1 pattern(s) tried: ['users/(?P<slug>[-_\\w\\@\\.]+)/$']

Another solution:

• Accept + for existing users in https://github.com/python/pythondotorg/blob/master/users/urls.py#L17
• Reject + in user registration form: https://github.com/python/pythondotorg/blob/master/users/forms.py#L13

[berkerpeksag]

Accept + for existing users in https://github.com/python/pythondotorg/blob/master/users/urls.py#L17

This was done in c52fb5e.

[berkerpeksag]

Added a test case for this in #809.